Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use relative paths in nitro-config.d.ts #2471

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#24869

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

By emitting relative paths in nitro-config.d.ts, we ensure that the types still work when developing in a Docker container where the absolute path does not match the path the IDE is running in.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working types labels May 24, 2024
@danielroe danielroe requested a review from pi0 May 24, 2024 20:52
@danielroe danielroe self-assigned this May 24, 2024
@pi0 pi0 merged commit 4d70b75 into main May 27, 2024
5 checks passed
@pi0 pi0 deleted the fix/relative-cfg-types branch May 27, 2024 08:49
@pi0 pi0 mentioned this pull request Jun 13, 2024
pi0 pushed a commit that referenced this pull request Jun 27, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants