Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(public-assets): do not shadow paths that share prefix #2516

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Encountered this as a side effect of replicating another bug.

Registering public asset dir with a base URL of, say, /custom will lead to paths like /custom-thing also being handled by the same handler (and returning a hard 404 if fallthrough is disabled). This is because we do not test if the path begins with /custom/ but with /custom.

Let me know if you need me to provide a reproduction. I think the problem and fix are straightforward to see, but happy to do so!

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 12, 2024
@danielroe danielroe requested a review from pi0 June 12, 2024 11:52
@danielroe danielroe self-assigned this Jun 12, 2024
@pi0 pi0 merged commit 72db848 into main Jun 12, 2024
5 checks passed
@pi0 pi0 deleted the fix/public-asset-shadow branch June 12, 2024 13:50
@pi0 pi0 mentioned this pull request Jun 13, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants