Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify): ensure preview command is correct #2561

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#24015

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

You can also reproduce locally - the issue is that relative paths are resolved relative to output.dir which is not overridden in these netlify presets. And in fact no static directory is produced.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working preset:netlify labels Jun 25, 2024
@danielroe danielroe requested a review from pi0 June 25, 2024 17:11
@danielroe danielroe self-assigned this Jun 25, 2024
@pi0 pi0 merged commit d16a47b into v2 Jun 25, 2024
5 checks passed
@pi0 pi0 deleted the fix/netlify-previeew branch June 25, 2024 17:18
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preset:netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt generate says you can preview using npx serve .output/static, but the actual content is in **dist**
2 participants