feat: add genezio preset #2637
Merged
feat: add genezio preset #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added genezio preset * Auto-generate genezio file * Enable custom names and default region for yaml file * Create genezio.yaml * Basic draft of genezio.md file * Update genezio.md * Update for the auto-generation of the yaml files * Update index.ts * Update genezio.md * Update genezio.md * Update genezio.md * Update genezio.md * Update genezio.md * Update genezio.md Co-authored-by: Andreia OcΔnoaia <andreia.ocanoaia@gmail.com> * Update genezio.md * Update genezio.md * Update genezio.md * Reverted the accidental changes to _all.gen * Reverted the playground changes * Update genezio.md --------- Co-authored-by: Andreia OcΔnoaia <andreia.ocanoaia@gmail.com>
|
Hey @pi0, I've tested this feature and it's ready for a code review. Feel free to add yourself as a reviewer anytime. |
pi0
reviewed
Sep 5, 2024
src/presets/genezio/preset.ts
Outdated
| }, | ||
| { | ||
| name: "genezio" as const, | ||
| stdName: "genezio", |
There was a problem hiding this comment.
stdName needs to be recognized with unjs/std-env
pi0
reviewed
Sep 5, 2024
src/presets/genezio/utils.ts
Outdated
| const name = await getNameFromPackage(); | ||
| const initialPath = dirname(nitro.options.output.dir); | ||
| const genezioConfigPath = resolve(initialPath, "genezio.yaml"); | ||
| const genezioConfigContent = ` |
There was a problem hiding this comment.
Normally zero config nitro presets use a special "output directory" that is supported by deployment providers instead of writing to project root (which is version controlled)
If manual file is required, we should keep it as docs only (i would be happy to explain this more if you like to integrate zero deploy with your platform)
pi0
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Geneziois a Function-as-a-Service (FaaS) platform designed to deploy serverless applications efficiently, minimizing both costs and cold start times.I have introduced a new preset named
--genezio. This preset provides users with additional configuration options, allowing for more flexibility and customization.Additionally, I have updated the documentation to reflect these changes, ensuring that users can easily understand and utilize the new preset.
π Checklist