Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reproducible builds using SOURCE_DATE_EPOCH #2646

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

peterhirn
Copy link

@peterhirn peterhirn commented Aug 8, 2024

πŸ”— Linked issue

#2645

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If environment variable SOURCE_DATE_EPOCH is set (number seconds since the Unix epoch) use this timestamp instead of new Date() and mtime. See linked issue for more context.

Resolves #2645

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

TODO

  • Documentation (is a change to the docs for this feature desired?)
  • Preferred code formatting/style (please advice on how you would like this code to be formatted)
  • Investigate if there are additional new Date() or mtime calls to patch
  • Investigate if fixed mtime can introduce bugs at runtime
  • e2e test (atm I only tested this using pnpm patch)
  • merge to v3 (or would you prefer to create this pr against main, then backport?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reproducible builds using SOURCE_DATE_EPOCH
1 participant