Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export runtime types directly from nitropack #301

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

danielroe
Copy link
Member

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Otherwise users wanting to use a type like NitroApp or NitroAppPlugin would have to do something like:

import { NitroApp } from 'nitropack/dist/runtime/app'

...or use an internal nitro alias.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 June 20, 2022 10:14
@danielroe danielroe self-assigned this Jun 20, 2022
src/types/index.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 34b8c4d into main Jun 20, 2022
@pi0 pi0 deleted the fix/runtime-types branch June 20, 2022 12:01
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
* fix: export runtime types directly from `nitropack`

* refactor: use `runtime/types`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants