-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct type inference for routes #518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
fix(types): correct type inference for routes
test: correct type inference for routes
Sep 19, 2022
pi0
reviewed
Sep 19, 2022
danielroe
force-pushed
the
test/strict-type-test
branch
from
September 28, 2022 22:16
0b72bef
to
036e555
Compare
7 tasks
Codecov Report
@@ Coverage Diff @@
## main nuxt/framework#518 +/- ##
==========================================
+ Coverage 66.21% 66.25% +0.04%
==========================================
Files 56 56
Lines 4129 4134 +5
Branches 445 446 +1
==========================================
+ Hits 2734 2739 +5
Misses 1391 1391
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danielroe
changed the title
test: correct type inference for routes
fix: correct type inference for routes
Oct 16, 2022
@danielroe Can you please fix merge conflict? |
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
Co-authored-by: David Tai <didavid61202@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#14850, nuxt/nuxt#15116
β Type of change
π Description
toMatchTypeOf
can be misleading - this updates test for greater strictness. There are a few issues that appear in consequence; I'm marking PR as draft until we can fix them.π Checklist