-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: normalize route options and shortcuts #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Oct 15, 2022
Co-authored-by: Daniel Roe <daniel@roe.dev>
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 66.01% 66.11% +0.09%
==========================================
Files 55 55
Lines 4061 4099 +38
Branches 439 439
==========================================
+ Hits 2681 2710 +29
- Misses 1376 1385 +9
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
changed the title
refactor: normalize
refactor: normalize route options before passing to runtime
Oct 15, 2022
cors
route options to header options
pi0
changed the title
refactor: normalize route options before passing to runtime
refactor: normalize route options and shortcuts
Oct 15, 2022
pi0
changed the title
refactor: normalize route options and shortcuts
feat: normalize route options and shortcuts
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #538
By normalizing route options, we can support more shortcuts and also avoid duplicate logic per vendor for native support.
This PR normalizes 3 shortcuts:
Also fixes some issues with netlify and vercel generated rules