fix: normalize #build windows path for dev and prerender presets
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Apr 11, 2022
| 'nitro:rollup:before' (nitro) { | ||
| if (isWindows) { | ||
| // Windows dynamic imports should be file:// url | ||
| nitro.options.alias['#build'] = pathToFileURL(nitro.options.buildDir).href |
There was a problem hiding this comment.
Shared situation with both is externals: { trace: false }
There was a problem hiding this comment.
Hm. Perhaps we could just test for that instead in rollup config, or are you happy with the preset option?
There was a problem hiding this comment.
Improved in 1ec2ee4. Extending alias was too late here.
pi0
reviewed
Apr 11, 2022
pi0
approved these changes
Apr 11, 2022
pi0
changed the title
#build windows path for dev and prerender presets
pi0
reviewed
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/framework#4232
❓ Type of change
📚 Description
The fix applied to dev preset also needs to be applied to prerender preset. It seemed easiest way was to extract from options and add to preset itself. There may be a better way to do this.
📝 Checklist