fix(netlify, vercel): order route rules from most specific + avoid double-rendering root

src/presets/netlify.ts

@@ -84,18 +84,22 @@ async function writeRedirects(nitro: Nitro) {
   const redirectsPath = join(nitro.options.output.publicDir, "_redirects");
   let contents = "/* /.netlify/functions/server 200";
 
+  const rules = Object.entries(nitro.options.routeRules).sort(
+    (a, b) => a[0].split(/\/(?!\*)/).length - b[0].split(/\/(?!\*)/).length
+  );
+
   // Rewrite static cached paths to builder functions
-  for (const [key] of Object.entries(nitro.options.routeRules).filter(
+  for (const [key] of rules.filter(
     ([_, routeRules]) =>
       routeRules.cache && (routeRules.cache?.static || routeRules.cache?.swr)
   )) {
     contents =
       `${key.replace("/**", "/*")}\t/.netlify/builders/server 200\n` + contents;
   }
 
-  for (const [key, routeRules] of Object.entries(
-    nitro.options.routeRules
-  ).filter(([_, routeRules]) => routeRules.redirect)) {
+  for (const [key, routeRules] of rules.filter(
+    ([_, routeRules]) => routeRules.redirect
+  )) {
     // TODO: Remove map when netlify support 307/308
     let code = routeRules.redirect.statusCode;
     code = { 307: 302, 308: 301 }[code] || code;
@@ -125,9 +129,13 @@ async function writeHeaders(nitro: Nitro) {
   const headersPath = join(nitro.options.output.publicDir, "_headers");
   let contents = "";
 
-  for (const [path, routeRules] of Object.entries(
-    nitro.options.routeRules
-  ).filter(([_, routeRules]) => routeRules.headers)) {
+  const rules = Object.entries(nitro.options.routeRules).sort(
+    (a, b) => b[0].split(/\/(?!\*)/).length - a[0].split(/\/(?!\*)/).length
+  );
+
+  for (const [path, routeRules] of rules.filter(
+    ([_, routeRules]) => routeRules.headers
+  )) {
     const headers = [
       path.replace("/**", "/*"),
       ...Object.entries({ ...routeRules.headers }).map(

src/presets/vercel.ts

@@ -43,11 +43,11 @@ export const vercel = defineNitroPreset({
       );
 
       // Write prerender functions
-      for (const [key, value] of Object.entries(
-        nitro.options.routeRules
-      ).filter(
+      const rules = Object.entries(nitro.options.routeRules).filter(
         ([_, value]) => value.cache && (value.cache.swr || value.cache.static)
-      )) {
+      );
+
+      for (const [key, value] of rules) {
         if (!value.cache) {
           continue;
         } // for type support
@@ -121,6 +121,10 @@ export const vercelEdge = defineNitroPreset({
 });
 
 function generateBuildConfig(nitro: Nitro) {
+  const rules = Object.entries(nitro.options.routeRules).sort(
+    (a, b) => b[0].split(/\/(?!\*)/).length - a[0].split(/\/(?!\*)/).length
+  );
+
   return defu(nitro.options.vercel?.config, <VercelBuildConfigV3>{
     version: 3,
     overrides: Object.fromEntries(
@@ -132,7 +136,7 @@ function generateBuildConfig(nitro: Nitro) {
       ])
     ),
     routes: [
-      ...Object.entries(nitro.options.routeRules)
+      ...rules
         .filter(([_, routeRules]) => routeRules.redirect || routeRules.headers)
         .map(([path, routeRules]) => {
           let route = {
@@ -159,10 +163,8 @@ function generateBuildConfig(nitro: Nitro) {
           },
           continue: true,
         })),
-      {
-        handle: "filesystem",
-      },
-      ...Object.entries(nitro.options.routeRules)
+      { handle: "filesystem" },
+      ...rules
         .filter(
           ([key, value]) =>
             value.cache &&
@@ -173,10 +175,20 @@ function generateBuildConfig(nitro: Nitro) {
           src: key.replace(/^(.*)\/\*\*/, "(?<url>$1/.*)"),
           dest: generateEndpoint(key) + "?url=$url",
         })),
-      {
-        src: "/(.*)",
-        dest: "/__nitro",
-      },
+      // If we are using a prerender function as a fallback, then we do not need to output
+      // the below fallback route as well
+      ...(!nitro.options.routeRules["/**"]?.cache ||
+      !(
+        nitro.options.routeRules["/**"].cache.swr ||
+        nitro.options.routeRules["/**"]?.cache.static
+      )
+        ? [
+            {
+              src: "/(.*)",
+              dest: "/__nitro",
+            },
+          ]
+        : []),
     ],
   });
 }

test/presets/netlify.test.ts

@@ -41,8 +41,8 @@ describe("nitro:preset:netlify", async () => {
     /* eslint-disable no-tabs */
     expect(redirects).toMatchInlineSnapshot(`
       "/rules/nested/override	/other	302
-      /rules/nested/*	/base	302
       /rules/redirect/obj	https://nitro.unjs.io/	301
+      /rules/nested/*	/base	302
       /rules/redirect	/base	302
       /rules/swr-ttl/*	/.netlify/builders/server 200
       /rules/swr/*	/.netlify/builders/server 200

test/presets/vercel.test.ts

@@ -43,6 +43,20 @@ describe("nitro:preset:vercel", async () => {
           },
         },
         "routes": [
+          {
+            "headers": {
+              "Location": "https://nitro.unjs.io/",
+            },
+            "src": "/rules/redirect/obj",
+            "status": 308,
+          },
+          {
+            "headers": {
+              "Location": "/other",
+            },
+            "src": "/rules/nested/override",
+            "status": 307,
+          },
           {
             "headers": {
               "cache-control": "s-maxage=60",
@@ -65,13 +79,6 @@ describe("nitro:preset:vercel", async () => {
             "src": "/rules/redirect",
             "status": 307,
           },
-          {
-            "headers": {
-              "Location": "https://nitro.unjs.io/",
-            },
-            "src": "/rules/redirect/obj",
-            "status": 308,
-          },
           {
             "headers": {
               "Location": "/base",
@@ -80,13 +87,6 @@ describe("nitro:preset:vercel", async () => {
             "src": "/rules/nested/.*",
             "status": 307,
           },
-          {
-            "headers": {
-              "Location": "/other",
-            },
-            "src": "/rules/nested/override",
-            "status": 307,
-          },
           {
             "continue": true,
             "headers": {