Skip to content

Commit

Permalink
fix: workaround for vue 3.2.18+ esm bundle issue and revert #566 (#578
Browse files Browse the repository at this point in the history
) (#578)
  • Loading branch information
danielroe authored Sep 29, 2021
1 parent c4bb1e6 commit e60d22a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/build.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export default defineBuildConfig({
'ora',
'vue-bundle-renderer',
'vue-server-renderer',
'@vue/server-renderer',
'vue'
]
})
1 change: 0 additions & 1 deletion src/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"@rollup/pluginutils": "^4.1.1",
"@types/jsdom": "^16.2.13",
"@vercel/nft": "^0.15.0",
"@vue/server-renderer": "^3.2.19",
"archiver": "^5.3.0",
"chalk": "^4.1.2",
"chokidar": "^3.5.2",
Expand Down
7 changes: 7 additions & 0 deletions src/rollup/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@ export const getRollupConfig = (nitroContext: NitroContext) => {
env.polyfill.push('source-map-support/register.js')
}

// TODO: #590
if (nitroContext._nuxt.majorVersion === 3) {
env.alias['vue/server-renderer'] = 'vue/server-renderer'
env.alias['vue/compiler-sfc'] = 'vue/compiler-sfc'
env.alias.vue = require.resolve(`vue/dist/vue.cjs${nitroContext._nuxt.dev ? '' : '.prod'}.js`)
}

const buildServerDir = join(nitroContext._nuxt.buildDir, 'dist/server')
const runtimeAppDir = join(nitroContext._internal.runtimeDir, 'app')

Expand Down
2 changes: 1 addition & 1 deletion src/runtime/app/vue3.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// @ts-ignore
import { renderToString as render } from '@vue/server-renderer'
import { renderToString as render } from 'vue/server-renderer'

export const renderToString: typeof render = (...args) => {
return render(...args).then(result => `<div id="__nuxt">${result}</div>`)
Expand Down

0 comments on commit e60d22a

Please sign in to comment.