Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(externals): rewrite traced file paths to latest semver-minor version #578

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

previously: #529

resolves #526, nuxt/nuxt#14995

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Note: This is a hotfix (which might solve issue in some cases where the site would be otherwise completely broken). We still need a proper solution via #572.

Currently, if we trace file a from v 7.1 and file b from v 7.0 of a putative package, we discard b entirely. This PR changes the behaviour to copy across b from v 7.1. This isn't a perfect fix as we stil may have issues with major version differences, but it can resolve small differences, for example in nuxt/nuxt#14995.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Oct 14, 2022
@danielroe danielroe requested a review from pi0 October 14, 2022 13:25
@danielroe danielroe self-assigned this Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #578 (b843b53) into main (8244d8a) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     nuxt/framework#578      +/-   ##
==========================================
+ Coverage   66.09%   66.11%   +0.01%     
==========================================
  Files          55       55              
  Lines        4056     4061       +5     
  Branches      438      441       +3     
==========================================
+ Hits         2681     2685       +4     
- Misses       1371     1372       +1     
  Partials        4        4              
Impacted Files Coverage Ξ”
src/rollup/plugins/externals.ts 88.19% <85.71%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: fallback traced files for minor/patch versions fix(externals): rewrite traced file paths to latest semver-minor version Oct 15, 2022
@pi0 pi0 merged commit 7aa0925 into main Oct 15, 2022
@pi0 pi0 deleted the fix/trace-minors branch October 15, 2022 11:28
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants