-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(externals): fallback traced files for minor/patch versions #529
Conversation
Codecov Report
@@ Coverage Diff @@
## main nuxt/bridge#106 +/- ##
==========================================
+ Coverage 66.09% 66.11% +0.01%
==========================================
Files 55 55
Lines 4056 4061 +5
Branches 438 441 +3
==========================================
+ Hits 2681 2685 +4
- Misses 1371 1372 +1
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'm reverting this PR. Mixing two files of two different package versions is not a nice idea! At least for mentioned node-fetch-native, we might find a better solution and for other possible cases, think of supporting hosting for trace extraction. |
Very happy for this to be reverted. It was only meant to be a hotfix. The current externals tracing implementation is fairly fragile; even differing patch versions of a package may cause 500 errors on deploy. There are also other issues regarding differing major versions. Probably all of these can be solved by reworking the implementation. |
Indeed it is fraglie and broken if internal structure of package changes in semver/minor.. Moved discussion to #572 would be nice if you can share your input on plan and also if any other open issues are relevant to link. |
Also, just in case you missed it, this didn't copy files across/mix files from two different versions. |
π Linked issue
resolves #526, nuxt/nuxt#14995
β Type of change
π Description
Currently, if we trace file
a
from v 7.1 and fileb
from v 7.0 of a putative package, we discardb
entirely. This PR changes the behaviour to copy acrossb
from v 7.1. This isn't a perfect fix as we stil may have issues with major version differences, but it can resolve small differences, for example in nuxt/nuxt#14995.π Checklist