Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow overriding nested runtime config #65

Merged
merged 5 commits into from
Apr 12, 2022
Merged

feat: allow overriding nested runtime config #65

merged 5 commits into from
Apr 12, 2022

Conversation

danielroe
Copy link
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently it isn't possible to set nested config, which is something needed in frameworks like Nuxt.

See for example nuxt/nuxt#13641 - currently we are not able to override anything but top-level publicRuntimeConfig.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 9, 2022
@danielroe danielroe requested a review from pi0 April 9, 2022 21:36
@danielroe danielroe self-assigned this Apr 9, 2022
pi0
pi0 reviewed Apr 11, 2022
View reviewed changes
src/runtime/config.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 April 12, 2022 09:30
@pi0 pi0 added enhancement New feature or request and removed bug Something isn't working labels Apr 12, 2022
@pi0 pi0 changed the title fix: allow overriding nested runtime config feat: allow overriding nested runtime config Apr 12, 2022
@pi0 pi0 merged commit 27fb68b into main Apr 12, 2022
@pi0 pi0 deleted the fix/nested-runtime-config branch April 12, 2022 10:06
@danielroe danielroe mentioned this pull request Apr 22, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0