New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-13: Make parse optional #14

Closed

chrstnfrrs wants to merge 2 commits into unjs:main from chrstnfrrs:main

Contributor

chrstnfrrs commented Sep 16, 2021

Closes: #13

Description
This PR aims to make parsing optional.

It creates a new object to pass through as options, setting parse to true and then spreading consumer options. This will overwrite the parse set to true, if parse is passed through.
If parse is set, then it parses the JSON body and automatically adds headers. If parse is set to false, then body is maintained and headers are not changed.
Parse is added to the FetchOptions type as an optional boolean.

chrstnfrrs added 2 commits

September 15, 2021 20:37


          feat: allow for parse to be disabled

c0a7258


          refactor: simplify conditionals

e23c66d

Contributor Author

chrstnfrrs commented Sep 16, 2021

I misunderstood what the Issue was requesting. This solution is incorrect and I will open a new :pr: with the correct solution.

chrstnfrrs closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet