fix: fix exports for node #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 5 5
Lines 323 323
Branches 59 59
=======================================
Hits 277 277
Misses 46 46 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nozomuikuta
commented
Jan 30, 2023
Comment on lines
+7
to
+10
| exports.ofetch.create = defaultOptions => getExport("ofetch").then($fetch => $fetch.create(defaultOptions)); | ||
| exports.ofetch.raw = (input, init) => getExport("ofetch").then($fetch => $fetch.raw(input, init)); | ||
| exports.ofetch.native = (input, init) => getExport("ofetch").then($fetch => $fetch.native(input, init)); | ||
|
|
There was a problem hiding this comment.
Since ofetch is actually $fetch, I added these exports.
Line 20 in 5943c5f
pi0
reviewed
Jan 30, 2023
| exports.ofetch = createCaller("ofetch"); | ||
| exports.ofetch.create = defaultOptions => getExport("ofetch").then($fetch => $fetch.create(defaultOptions)); |
There was a problem hiding this comment.
We need to return a sync version of fetch that itself has raw/native/etc
|
Thanks for the PR dear @nozomuikuta. Since issues with CJS support is now resolved using node-fetch-native with CJS support, i'm thinking to completely drop this stub. |
|
Oh, I see then let me close this PR. 🙆♂️ |
|
~> #211 |
|
Great work! fixed the issue for me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198
I tested this PR in the following way:
node_modulesas this PRrequire('ofetch')(fromexports["."]["node"]["require"]inpackage.jsonrequire('ofetch')(fromexports["default"]["require"]inpackage.json(with.subpath deleted in the file for fallback to work)require('ofetch/node')(fromexports["./node"]["require"]inpackage.json