Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support retryDelay #262

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: support retryDelay #262

merged 1 commit into from
Aug 16, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Aug 8, 2023

πŸ”— Linked issue

nitrojs/nitro#1534
Resolves #261

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Implements a retryDelay parameters that default to 100ms.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious requested a review from pi0 August 8, 2023 13:17
@Hebilicious Hebilicious added the enhancement New feature or request label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #262 (d35226b) into main (5f95a88) will decrease coverage by 0.12%.
The diff coverage is 85.71%.

❗ Current head d35226b differs from pull request most recent head dece4c7. Consider uploading reports for the commit dece4c7 to get more accurate results

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   90.47%   90.36%   -0.12%     
==========================================
  Files           5        5              
  Lines         462      467       +5     
  Branches       75       76       +1     
==========================================
+ Hits          418      422       +4     
- Misses         44       45       +1     
Files Changed Coverage Ξ”
src/fetch.ts 94.30% <85.71%> (-0.30%) ⬇️

@pi0 pi0 changed the title feat: implement retry delay feat: support retryDelay Aug 16, 2023
@pi0 pi0 force-pushed the feat/retry-delay branch from d35226b to dece4c7 Compare August 16, 2023 14:35
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ’―

@pi0 pi0 merged commit 4cacd14 into main Aug 16, 2023
@pi0 pi0 deleted the feat/retry-delay branch August 16, 2023 14:40
@pi0 pi0 mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] retry delay
2 participants