Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify retry behavior #264

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

picunada
Copy link
Contributor

Added explanation in which cases retry occur.

πŸ”— Linked issue

Issue #263 .

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added an explanation in which cases retries occurs to avoid confusion.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Added explanation in which cases retry occur.
Issue unjs#263 .
@pi0 pi0 changed the title docs: added explanation in which cases retry occur docs: clarify retry behavior Aug 16, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :100

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #264 (c5f9810) into main (41c3b56) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head c5f9810 differs from pull request most recent head 0c957b2. Consider uploading reports for the commit 0c957b2 to get more accurate results

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files           5        5           
  Lines         462      462           
  Branches       74       74           
=======================================
  Hits          418      418           
  Misses         44       44           
Files Changed Coverage Ξ”
src/utils.ts 95.49% <100.00%> (ΓΈ)

@pi0 pi0 merged commit 98cd26f into unjs:main Aug 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants