perf(object-hash): faster extract object type from toString #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Apr 22, 2023
| objType = "unknown:[" + objString + "]"; | ||
| } else { | ||
| // '[object '.length === 8 | ||
| objType = objString.slice(8, objectLength - 1); |
There was a problem hiding this comment.
This can introduce a regression of string is not ending with ] (which regex was testing before)
There was a problem hiding this comment.
From what I see and test, is impossible to see a string not ending with ], so it's not a problem.
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 80.37% 80.51% +0.14%
==========================================
Files 8 8
Lines 968 975 +7
Branches 125 126 +1
==========================================
+ Hits 778 785 +7
Misses 190 190
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by puleos/object-hash#122
perf: faster extract object type from toString
Using slice again instead of Regex.