fix(isUppercase): assume characters lowercase by default #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #69
β Type of change
π Description
isUppercase
is used to returntrue
for nonalphabetic characters such as-
. This issue was not visible for thesplitByCase
util without custom splitters.The fix checkes if string could be lowecased, it is an uppercase. (also adds tiny perf because the frequency of passed lowercase strings is much higher and it saves v8 engine to do anything for most of
toLowercase()
callsπ Checklist