Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace fast-glob with tinyglobby #426

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented Aug 15, 2024

fast-glob - 17 subdependencies
tinyglobby - 2 subdependencies

https://github.com/es-tooling/module-replacements/blob/main/docs/modules/glob.md#tinyglobby

See unjs/mkdist#237

Like #418 but switches to an even smaller library

@pi0
Copy link
Member

pi0 commented Sep 25, 2024

Thanks! I might replace glob support later lib but seems better alternative.

@pi0 pi0 merged commit 40674c9 into unjs:main Sep 25, 2024
2 checks passed
@SuperchupuDev SuperchupuDev deleted the refactor/tinyglobby branch September 25, 2024 18:32
@Barbapapazes
Copy link
Member

Hey,

Don't the package fast-glob in the package.json be removed? 🤔

@pi0
Copy link
Member

pi0 commented Sep 25, 2024

Nice spot. removed for next rc (1a65aef)

@SuperchupuDev
Copy link
Contributor Author

@pi0 unfortunately fast-glob is still in the dependency tree until unjs/mkdist#237 gets merged

@pi0
Copy link
Member

pi0 commented Sep 27, 2024

As mentioned, it is mainly to experiment on beta releases until we make a stable decision for replacement across unjs tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants