fix(vue-2): rework how vue 2 plugin gets head instance #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vetruvet
force-pushed
the
vue-2-plugin-fix
branch
from
55dbae0 to
1ecc4de
Compare
|
Thank you! I appreciate the help on this, I think I have just been going around in circles. |
|
Glad to help! Thanks for maintaining this package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make vue 2 plugin not reference head directly, get it from root component options instead
🔗 Linked issue
#216
❓ Type of change
📚 Description
The comment in 1dfe189 about the pinia plugin sparked a thought for an alternative way for the plugin to work. Basically instead of passing the unhead instance to
Vue.use, have the plugin get it fromthis.$options.unhead(which would only be present on the root component).The changes in 1dfe189 would still result in the behavior described here.
📝 Checklist