Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): prefer ReturnType instead of infer #415

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

huang-julien
Copy link
Contributor

may fix nuxt/scripts#320 (comment)

Hey 👋

this PR removes inferance from UseFunctionType. The reason is that inferance works really badly with function overload, returning only the last overload.

I hope this will be fixed in TS soon :/

@huang-julien
Copy link
Contributor Author

huang-julien commented Nov 18, 2024

we also need to find a way to Primisify function overload return type for AsAsyncFunctionValues

@harlan-zw
Copy link
Collaborator

Thanks! I think I'll just need to do some testing before doing a release

@harlan-zw harlan-zw merged commit 0460f9e into unjs:main Nov 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Types for gtag function params
2 participants