Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: azure-app-configuration driver #156

Merged
merged 5 commits into from
Feb 27, 2023
Merged

feat: azure-app-configuration driver #156

merged 5 commits into from
Feb 27, 2023

Conversation

itpropro
Copy link
Member

No description provided.

@pi0 pi0 changed the title feat(driver): Added Azure App Configuration driver feat: azure-app-configuration driver Feb 27, 2023
pi0
pi0 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not tested. trusting works as expected)

@pi0 pi0 merged commit 017718d into main Feb 27, 2023
@pi0 pi0 deleted the feat/azure-app-config branch February 27, 2023 20:02
@itpropro
Copy link
Member Author

(not tested. trusting works as expected)

Testing will only work against a production instance, basically the same as with the cosmos driver. I tested all of the drivers against free and paid actual instances of the services.
Will also create a functional mock, in addition we should create a free instance of the app config in the shared Azure environment as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe Awaiting requested review from danielroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itpropro @pi0