Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for redis driver #164

Merged
merged 2 commits into from
Feb 27, 2023
Merged

test: add unit test for redis driver #164

merged 2 commits into from
Feb 27, 2023

Conversation

danielroe
Copy link
Member

Following #163, this enables unit testing with redis. We can then update the testDriver utility in that PR to add a regression test for the bug it is fixing.

@danielroe danielroe requested a review from pi0 February 23, 2023 16:18
@danielroe danielroe self-assigned this Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #164 (b8f6062) into main (1a9c013) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   89.36%   89.54%   +0.18%     
==========================================
  Files          15       16       +1     
  Lines        1344     1387      +43     
  Branches      303      317      +14     
==========================================
+ Hits         1201     1242      +41     
- Misses        143      145       +2     
Impacted Files Coverage Δ
src/drivers/redis.ts 95.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@itpropro
Copy link
Member

itpropro commented Feb 24, 2023

He @danielroe,
I already added tests, including different authentication methods to #160. They are not using a mock, but instead a in-memory actual redis implementation like the in-memory mongodb one in the mongodb driver.

@danielroe
Copy link
Member Author

Rats, how did I not see this?! That sounds better. I'll check later on.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 872fbbd into main Feb 27, 2023
@pi0 pi0 deleted the test/redis branch February 27, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants