Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(getKeys): avoid duplicate iteration #386

Merged
merged 4 commits into from
May 1, 2024
Merged

Conversation

GalacticHypernova
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We can avoid a duplicate filter operation if we use a traditional for of loop.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

src/storage.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 66.37%. Comparing base (4d61c78) to head (16dcb25).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   65.05%   66.37%   +1.31%     
==========================================
  Files          39       39              
  Lines        4055     4074      +19     
  Branches      487      509      +22     
==========================================
+ Hits         2638     2704      +66     
+ Misses       1408     1361      -47     
  Partials        9        9              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit f572ea7 into unjs:main May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants