Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix driver types #433

Merged
merged 3 commits into from
May 1, 2024
Merged

fix: fix driver types #433

merged 3 commits into from
May 1, 2024

Conversation

Gehbt
Copy link
Contributor

@Gehbt Gehbt commented Apr 29, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

commit: 8456a78
Driver utils deps a file that does not include the chunk
image

commit: 4f584a1
a type error happen at build, it lets build none
image
via npm
image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 66.24%. Comparing base (4d61c78) to head (4f584a1).
Report is 35 commits behind head on main.

❗ Current head 4f584a1 differs from pull request most recent head 4026112. Consider uploading reports for the commit 4026112 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   65.05%   66.24%   +1.19%     
==========================================
  Files          39       39              
  Lines        4055     4059       +4     
  Branches      487      504      +17     
==========================================
+ Hits         2638     2689      +51     
+ Misses       1408     1361      -47     
  Partials        9        9              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title chore(build-dts): fix declaration files at build fix(types): fix declaration files at build May 1, 2024
@pi0 pi0 changed the title fix(types): fix declaration files at build fix: fix driver types May 1, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find thanks!

@pi0 pi0 merged commit 687f785 into unjs:main May 1, 2024
2 checks passed
@Gehbt Gehbt deleted the patch-1 branch May 1, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants