fix(server): avoid decoding raw request body #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying unstorage with
|
| Latest commit: |
9215185
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2df9e22.unstorage.pages.dev |
| Branch Preview URL: | https://mannil-patch-1.unstorage.pages.dev |
TheAlexLichter
changed the title
|
Please consider making a minimal reproduction or add failing test (that fails without current changes) |
TheAlexLichter
force-pushed
the
manniL-patch-1
branch
from
80c3c77 to
3c51748
Compare
|
@pi0 Done! Added a fs-driver-based test to showcase the problem. The test fails in the original commit and is resolved by the proposed fix. |
pi0
changed the title
pi0
approved these changes
May 15, 2024
|
@pi0 Any chance to see this as part of a patch version soonish? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None (experienced while demoing for a video)
❓ Type of change
📚 Description
Right now, all binary files saved through the unstorage http server are not encoded correctly, as the default encoding is
"utf-8",even for these files. This PR fixes the behavior by not applyng any encoding when the file is marked as
raw, otherwise using the default utf8 encoding.📝 Checklist