Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cloudflare-kv-binding): add missing base argument on getKeys #475

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

atinux
Copy link
Member

@atinux atinux commented Sep 4, 2024

This will give the prefix and avoid looping through all the main namespace, this is an important fix in term of performance when dealing with a lot of keys.

Copy link

Deploying unstorage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 01734a0
Status: ✅  Deploy successful!
Preview URL: https://7ddb0a8c.unstorage.pages.dev
Branch Preview URL: https://fix-cf-kv-binding.unstorage.pages.dev

View logs

@pi0 pi0 changed the title fix(cloudflare): add missing base argument on getKeys fix(cloudflare-kv-binding): add missing base argument on getKeys Sep 4, 2024
@pi0 pi0 changed the title fix(cloudflare-kv-binding): add missing base argument on getKeys perf(cloudflare-kv-binding): add missing base argument on getKeys Sep 4, 2024
@pi0 pi0 merged commit 04bfe12 into main Sep 4, 2024
3 checks passed
@pi0 pi0 deleted the fix/cf-kv-binding branch September 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants