Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upstash driver #500

Merged
merged 24 commits into from
Dec 6, 2024
Merged

feat: add upstash driver #500

merged 24 commits into from
Dec 6, 2024

Conversation

fahreddinozcan
Copy link
Contributor

This PR adds Upstash Driver to drivers. Under the hood, it uses HTTP based @upstash/redis library, which differentiates it from the regular TCP based Redis driver. Also, vercel-kv is soon to be deprecated, and it's currently uses @upstash/redis under the hood. The Upstash Driver also aims to replace it.

@pi0 pi0 changed the title Upstash Storage Driver feat: add upstash driver Oct 31, 2024
@pi0 pi0 added the driver label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 43.13725% with 29 lines in your changes missing coverage. Please review.

Project coverage is 58.34%. Comparing base (4d61c78) to head (70161da).
Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/upstash.ts 43.13% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   65.05%   58.34%   -6.72%     
==========================================
  Files          39       40       +1     
  Lines        4055     3200     -855     
  Branches      487      527      +40     
==========================================
- Hits         2638     1867     -771     
+ Misses       1408     1324      -84     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascorbic
Copy link
Collaborator

Thanks @fahreddinozcan! This does need tests and docs adding before it can be merged. I think they can be based on the Vercel KV and/or Redis ones. It also needs adding to src/index.ts

src/drivers/upstash.ts Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 6caa7d6 into unjs:main Dec 6, 2024
@pi0 pi0 mentioned this pull request Dec 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants