-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add memcached
driver
#92
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Sanicboi Thanks for the PR ! @pi0 Memcached does not supports If there's demand for it, we can definitely do it in a later. I've implemented a way to skip the Also, the tests needs memcached to run, so I added that to the ci. The docs clearly reflects that |
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 76.94% 75.82% -1.12%
==========================================
Files 26 25 -1
Lines 3223 2809 -414
Branches 473 426 -47
==========================================
- Hits 2480 2130 -350
+ Misses 742 678 -64
Partials 1 1
|
Added memcached support. Had to change some functions and types due to the fact that they are not supported by memcached. For instance, memcached does not support getKeys.