fix: respect empty lines in example block #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying untyped with
|
| Latest commit: |
be5d453
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bcb50a40.untyped.pages.dev |
| Branch Preview URL: | https://fix-respect-example-multilin.untyped.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 57.90% 57.88% -0.03%
==========================================
Files 18 18
Lines 1872 1871 -1
Branches 284 284
==========================================
- Hits 1084 1083 -1
Misses 779 779
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Barbapapazes
changed the title
Barbapapazes
commented
Feb 25, 2024
pi0
reviewed
Sep 26, 2024
pi0
reviewed
Oct 5, 2024
| title: "", | ||
| tsType: "'src' | 'root'", | ||
| description: "", | ||
| tags: ["@note This is a note.", "```js\nexport default secret\n```"], |
There was a problem hiding this comment.
Shouldn't inline code go into the description?
There was a problem hiding this comment.
That's a good question. I don't know. What do you think? 🤷♂️
There was a problem hiding this comment.
But because there is the @, the title and description are the content above
see https://github.com/unjs/untyped/blob/main/src/loader/babel.ts#L253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR allow blank lines within example block.
related to unjs/h3#673 and to unjs/h3#672 where the extra line was always removed.
Previously, blank lines was automatically removed unless you use triple ` (backticks) to define the block. Now, you can write
and it will be rendered as
Before it was rendered as
📝 Checklist