fix: 🌐 Enable correct handling of undefined in api package fetch. (#2036

)

* 🎒 Mark rbac as external, allowing tests to pass locally.

* 🧪 Install `vitest` for apis client package.

* 🌐 Enable correct handling of undefined in api package fetch.

* 💱 Add changeset.

* Revert "🎒 Mark rbac as external, allowing tests to pass locally."

This reverts commit a20368b.

* 🧹 lintin'.

* 🔑 Update lock file.

* 🧹 lint.

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

.changeset/tall-needles-rhyme.md

@@ -0,0 +1,5 @@
+---
+"@unkey/api": patch
+---
+
+fix: 🌐 Correctly handle `undefined` values in API package fetch.

packages/api/package.json

@@ -18,14 +18,16 @@
   "author": "Andreas Thomas <andreas@chronark.com>",
   "scripts": {
     "generate": "openapi-typescript https://api.unkey.dev/openapi.json -o ./src/openapi.d.ts",
-    "build": "pnpm generate && tsup"
+    "build": "pnpm generate && tsup",
+    "test": "vitest run"
   },
   "devDependencies": {
     "@types/node": "^20.14.9",
     "@unkey/tsconfig": "workspace:^",
     "openapi-typescript": "^6.7.5",
     "tsup": "^8.0.2",
-    "typescript": "^5.5.3"
+    "typescript": "^5.5.3",
+    "vitest": "^1.6.0"
   },
   "dependencies": {
     "@unkey/rbac": "workspace:^"

packages/api/src/client.test.ts

@@ -0,0 +1,14 @@
+import { describe, expect, test } from "vitest";
+import { Unkey } from "./client";
+
+describe("client", () => {
+  test("fetch can encode the params without throwing", async () => {
+    const unkey = new Unkey({ token: "rawr" });
+    expect(() => {
+      unkey.apis.listKeys({
+        apiId: "meow",
+        cursor: undefined,
+      });
+    }).not.toThrow();
+  });
+});

packages/api/src/client.ts

@@ -157,7 +157,7 @@ export class Unkey {
       const url = new URL(`${this.baseUrl}/${req.path.join("/")}`);
       if (req.query) {
         for (const [k, v] of Object.entries(req.query)) {
-          if (v === null) {
+          if (typeof v === "undefined" || v === null) {
             continue;
           }
           url.searchParams.set(k, v.toString());