-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor web #152
chore: refactor web #152
Conversation
@Bekacru is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
also there is a duplicated component for delete-api I prefixed it with _ for now, it's not imported anywhere if it is no longer needed, we can remove it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @Bekacru We just released our new landing page. To finish this work up, please sync with main and make sure that all styles still work, and that nothing broke for you. Can you also move the components too a folder called |
Hey james, congra with the new landing page. I checked and It doesn't break any style from the landing page and moved the dashbaord components to |
renaming components, moving components in the app dir to the components folder, removing unused imports, removing unnecessary comments and running the linter.
And as a suggestion in general I think it's a good idea to keep all components just in components folder without subfolders unless there is an actual need to group some components.
let me know if I miss anything :)