Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor web #152

Merged
merged 6 commits into from
Jul 21, 2023
Merged

chore: refactor web #152

merged 6 commits into from
Jul 21, 2023

Conversation

Bekacru
Copy link
Contributor

@Bekacru Bekacru commented Jul 20, 2023

renaming components, moving components in the app dir to the components folder, removing unused imports, removing unnecessary comments and running the linter.

And as a suggestion in general I think it's a good idea to keep all components just in components folder without subfolders unless there is an actual need to group some components.

let me know if I miss anything :)

@vercel
Copy link

vercel bot commented Jul 20, 2023

@Bekacru is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@Bekacru
Copy link
Contributor Author

Bekacru commented Jul 20, 2023

also there is a duplicated component for delete-api I prefixed it with _ for now, it's not imported anywhere if it is no longer needed, we can remove it.

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unkey ❌ Failed (Inspect) Jul 21, 2023 2:55pm

@perkinsjr
Copy link
Collaborator

Hey @Bekacru

We just released our new landing page.

To finish this work up, please sync with main and make sure that all styles still work, and that nothing broke for you. Can you also move the components too a folder called dashboard so that landing and dashboard are separated this is so if we ever move from a monorepo to a separate marketing we can.

@Bekacru
Copy link
Contributor Author

Bekacru commented Jul 21, 2023

Hey @Bekacru

We just released our new landing page.

To finish this work up, please sync with main and make sure that all styles still work, and that nothing broke for you. Can you also move the components too a folder called dashboard so that landing and dashboard are separated this is so if we ever move from a monorepo to a separate marketing we can.

Hey james, congra with the new landing page. I checked and It doesn't break any style from the landing page and moved the dashbaord components to dashboard folder

@perkinsjr perkinsjr requested a review from chronark July 21, 2023 12:33
@chronark chronark merged commit b95acfc into unkeyed:main Jul 21, 2023
@chronark chronark mentioned this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants