Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key 33 api endpoint to update a key #156

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

chronark
Copy link
Collaborator

  • wip
  • only change defined fields

@linear
Copy link

linear bot commented Jul 20, 2023

KEY-33 API endpoint to update a key

These fields should be updatable:

  • ratelimit
  • limit
  • meta
  • ownerId
  • expires

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unkey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 8:58am

Copy link
Collaborator

@perkinsjr perkinsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a spelling error but looks good.

Lets gooooooo

test(key_update_test.go): remove logging of response body in test cases
test(key_update_test.go): add test case for updating key without affecting undefined fields
@chronark chronark merged commit cf50225 into main Jul 21, 2023
@chronark chronark deleted the key-33-api-endpoint-to-update-a-key branch July 21, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants