Fix vibration detection #1076
Merged
Fix vibration detection #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormatting and refactor variable access to be DRY
|
This appears to be fixing the same issue as #813 as well. |
|
Thanks! Lets get this merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix here is that on my Mac Studio, vibrationActuator is null, not undefined. So using the type accessor against that variable causes an exception. Simple fix to check for both. I also just submitted a similar fix to the related xbox-xcloud-player repo.
Also fixes a typo in phrasing. "active it" to "activate it".
Rest is cosmetic multiline formatting cleanup and cleanup of some variables that are reused over and over again.