Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(unlock-app): Support cross-chain + swap payments for renewals #15406

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Jan 31, 2025

Description

This PR introduces support for cross-chain and swap payments (via Relay) during checkout for renewals and extensions, allowing users to seamlessly pay with assets from different chains.

Example

renewed an expired key priced in eth on base, using eth on the arbitrum chain.
https://arbiscan.io/tx/0xe7133bb7cb012c136b1ec140173b3194b09688ba345a67abb74b34abbfb699a7

Issues

Fixes #15284
Refs #15284

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 January 31, 2025 15:12
@cla-bot cla-bot bot added the cla-signed label Jan 31, 2025
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Feb 5, 2025 0:01am
unlock-storybook ⬜️ Ignored (Inspect) Feb 5, 2025 0:01am

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor neat to avoid duplicating code!

@0xTxbi 0xTxbi merged commit c005402 into master Feb 5, 2025
15 checks passed
@0xTxbi 0xTxbi deleted the crosschain-renewals branch February 5, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crosschain + swap payments for renewals
2 participants