perf: dont compile for empty expressions

unnamed · Dec 28, 2023 · 5efc56a · 5efc56a
1 parent bc6166b
commit 5efc56a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/main/java/team/unnamed/mocha/runtime/MochaFunction.java b/src/main/java/team/unnamed/mocha/runtime/MochaFunction.java
@@ -23,6 +23,7 @@
  */
 package team.unnamed.mocha.runtime;
 
+import org.jetbrains.annotations.NotNull;
 import team.unnamed.mocha.runtime.compiled.MochaCompiledFunction;
 
 /**
@@ -32,6 +33,10 @@
  */
 @FunctionalInterface
 public interface MochaFunction extends MochaCompiledFunction {
+    static @NotNull MochaFunction nop() {
+        return NopMochaFunctionHolder.NOP;
+    }
+
     /**
      * Evaluates this function.
      *
@@ -40,3 +45,7 @@ public interface MochaFunction extends MochaCompiledFunction {
      */
     double evaluate();
 }
+
+final class NopMochaFunctionHolder {
+    static final MochaFunction NOP = () -> 0D;
+}
diff --git a/src/main/java/team/unnamed/mocha/runtime/MolangCompiler.java b/src/main/java/team/unnamed/mocha/runtime/MolangCompiler.java
@@ -74,6 +74,12 @@ public MolangCompiler(final @NotNull ClassLoader classLoader, final @NotNull Glo
         requireNonNull(expressions, "expressions");
         requireNonNull(clazz, "clazz");
 
+        if (clazz == MochaFunction.class && expressions.isEmpty()) {
+            // no expressions and the target type is MochaFunction,
+            // we know the NOP function
+            return clazz.cast(MochaFunction.nop());
+        }
+
         if (!clazz.isInterface()) {
             throw new IllegalArgumentException("Target type must be an interface: " + clazz.getName());
         }