Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lightweight extension #838

Closed
wants to merge 3 commits into from
Closed

feat: add lightweight extension #838

wants to merge 3 commits into from

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

Added a lightweight/control extension and sample

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

unoplatform/uno.toolkit.ui#870
Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-838.eastus2.3.azurestaticapps.net

@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review August 1, 2023 18:21
@github-actions
Copy link

github-actions bot commented Aug 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-838.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-838.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-838.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-838.eastus2.3.azurestaticapps.net

agneszitte
agneszitte reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marc-Antoine-Soucy please fix the sample page name
LightWeightExtensionSamplePage instead of LightWeightExtensionSameplePage
image

@Xiaoy312 Should we even call it LightWeightSamplePage ?

@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-838.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-838.eastus2.3.azurestaticapps.net

@agneszitte agneszitte linked an issue Aug 30, 2023 that may be closed by this pull request
[ControlExtensions] Add CustomResources Attached Property unoplatform/uno.toolkit.ui#779
Closed
@agneszitte agneszitte marked this pull request as draft August 30, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 left review comments

@agneszitte agneszitte agneszitte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ControlExtensions] Add CustomResources Attached Property
3 participants
@Marc-Antoine-Soucy @Xiaoy312 @agneszitte