Skip to content

Commit

Permalink
Merge pull request #691 from unoplatform/dev/jela/winappsdk-workaround
Browse files Browse the repository at this point in the history
fix: Workaround for WinUI 3
  • Loading branch information
jeromelaban authored Dec 2, 2021
2 parents 149fca4 + ee5a23a commit 58cbfb1
Show file tree
Hide file tree
Showing 6 changed files with 46 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/library/Uno.Material/Styles/Controls/Button.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@
<Setter Property="UseSystemFocusVisuals"
Value="True" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
Expand Down Expand Up @@ -221,6 +225,10 @@
<Setter Property="UseSystemFocusVisuals"
Value="True" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
Expand Down Expand Up @@ -389,6 +397,11 @@
Value="{ThemeResource MaterialButtonFontSize}" />
<Setter Property="UseSystemFocusVisuals"
Value="True" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
Expand Down
4 changes: 4 additions & 0 deletions src/library/Uno.Material/Styles/Controls/ComboBox.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,10 @@
<xamarin:Setter Property="uno:ComboBox.DropDownPreferredPlacement"
Value="Below" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="ItemsPanel">
<Setter.Value>
<ItemsPanelTemplate>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@
<Setter Property="Padding"
Value="{StaticResource MaterialFabLargePadding}" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
Expand Down Expand Up @@ -223,6 +227,10 @@
<Setter Property="Padding"
Value="{StaticResource MaterialFabSmallPadding}" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
Expand Down
8 changes: 8 additions & 0 deletions src/library/Uno.Material/Styles/Controls/PasswordBox.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@
<Setter Property="MinHeight"
Value="50" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="PasswordBox">
Expand Down Expand Up @@ -268,6 +272,10 @@
<Setter Property="MinHeight"
Value="50" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="PasswordBox">
Expand Down
8 changes: 8 additions & 0 deletions src/library/Uno.Material/Styles/Controls/TextBox.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@
<Setter Property="MinHeight"
Value="50" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="TextBox">
Expand Down Expand Up @@ -285,6 +289,10 @@
<Setter Property="MinHeight"
Value="50" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.Icon"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="TextBox">
Expand Down
5 changes: 5 additions & 0 deletions src/library/Uno.Material/Styles/Controls/ToggleButton.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,11 @@
Value="Center" />
<Setter Property="VerticalContentAlignment"
Value="Center" />

<!-- Workaround for WinUI issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6388 -->
<Setter Property="um:ControlExtensions.AlternateContent"
Value="{x:Null}" />

<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="ToggleButton">
Expand Down

0 comments on commit 58cbfb1

Please sign in to comment.