fix: add underlining for HyperlinkButton on WinUI

unoplatform · Oct 17, 2024 · c6f74f0 · c6f74f0
1 parent f90fe28
commit c6f74f0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/library/Uno.Cupertino/Styles/Controls/HyperlinkButton.xaml b/src/library/Uno.Cupertino/Styles/Controls/HyperlinkButton.xaml
@@ -5,6 +5,7 @@
 					mc:Ignorable="d">
 
 	<FontFamily x:Key="CupertinoHyperlinkButtonFontFamily">SF Pro</FontFamily>
+	<x:Boolean x:Key="HyperlinkUnderlineVisible">True</x:Boolean>
 	<x:String x:Key="MinusGlyphPathStyle">M0 1.67236H5.57812V0.327637H0V1.67236Z</x:String>
 
 	<Style x:Key="CupertinoHyperlinkButtonStyle"

diff --git a/src/library/Uno.Material/Styles/Controls/v1/HyperlinkButton.xaml b/src/library/Uno.Material/Styles/Controls/v1/HyperlinkButton.xaml
@@ -4,6 +4,8 @@
 					xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
 					mc:Ignorable="d">
 
+	<x:Boolean x:Key="HyperlinkUnderlineVisible">True</x:Boolean>
+
 	<Style x:Key="MaterialHyperlinkButtonStyle"
 		   TargetType="HyperlinkButton">
 

diff --git a/src/library/Uno.Material/Styles/Controls/v2/HyperlinkButton.xaml b/src/library/Uno.Material/Styles/Controls/v2/HyperlinkButton.xaml
@@ -6,7 +6,8 @@
 
     <ResourceDictionary.ThemeDictionaries>
         <ResourceDictionary x:Key="Default">
-            <StaticResource x:Key="HyperlinkButtonForeground" ResourceKey="PrimaryBrush" />
+	        <x:Boolean x:Key="HyperlinkUnderlineVisible">True</x:Boolean>
+	        <StaticResource x:Key="HyperlinkButtonForeground" ResourceKey="PrimaryBrush" />
             <StaticResource x:Key="HyperlinkButtonForegroundPointerOver" ResourceKey="PrimaryBrush" />
             <StaticResource x:Key="HyperlinkButtonForegroundPressed" ResourceKey="PrimaryBrush" />
             <StaticResource x:Key="HyperlinkButtonForegroundDisabled" ResourceKey="OnSurfaceLowBrush" />
@@ -33,6 +34,7 @@
 		</ResourceDictionary>
 
         <ResourceDictionary x:Key="Light">
+	        <x:Boolean x:Key="HyperlinkUnderlineVisible">True</x:Boolean>
             <StaticResource x:Key="HyperlinkButtonForeground" ResourceKey="PrimaryBrush" />
             <StaticResource x:Key="HyperlinkButtonForegroundPointerOver" ResourceKey="PrimaryBrush" />
             <StaticResource x:Key="HyperlinkButtonForegroundPressed" ResourceKey="PrimaryBrush" />