Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix AlternateContent for ToogleButton crashing on UWP when not set #1137

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

lesterbotello
Copy link
Contributor

GitHub Issue: #1132

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Adds a fallback value and target null value for AlternateContent binding

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested Gtk
  • [ ] Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

#1132

@agneszitte agneszitte merged commit 2a042fd into master Aug 15, 2023
10 checks passed
@agneszitte agneszitte deleted the dev/lebo/toggle-button-crash branch August 15, 2023 20:36
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 15, 2023

backport legacy/2x

✅ Backports have been created

agneszitte added a commit that referenced this pull request Aug 15, 2023
fix: Fix AlternateContent for ToogleButton crashing on UWP when not set (backport #1137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants