Update Uno.Extensions.Markup #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
force-pushed
the
dev/ds/resource-value-update
branch
from
fc2e886
to
d68f9f3
Compare
carldebilly
approved these changes
Sep 22, 2023
dansiegel
force-pushed
the
dev/ds/resource-value-update
branch
from
89bd575
to
bc4ab9c
Compare
dansiegel
force-pushed
the
dev/ds/resource-value-update
branch
from
bc4ab9c
to
c369e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
PR Type
What kind of change does this PR introduce?
Description
This updates to the latest Uno.WinUI.Markup and Markup Generator packages. This replaces the ResourceValue in Uno.Themes.WinUI.Markup with the ThemeResourceKey and StaticResourceKey from the Markup package to better support strong naming of values when overriding values for lightweight styling.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):