-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ToggleSwitch): Override ToggleSwitch MinWidth #1237
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1237.eastus2.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is that this will be a problem with the same sample if fluent theme is used instead of Cupertino/Material.
Yes, but we need this for the Figma Plugin release. So I created this issue (unoplatform/uno#13946) on Uno Core repo for us to track/fix later, and I'm sure it would take more discussion on what should be done. I will add this link to the Material/Cupertino styles for us to know why we have the |
Problem is, there is really nothing to fix on Uno side as we're matching WinUI :'( For now, I'm fine for the change being specific to Material/Cupertino |
I have left a comment on the other issue |
GitHub Issue: #1225
PR Type
What kind of change does this PR introduce?
Description
Added
<x:Double x:Key="ToggleSwitchThemeMinWidth">0</x:Double>
and<Setter Property="MinWidth" Value="{ThemeResource ToggleSwitchThemeMinWidth}" />
to prevent the extraMinWidth="154"
from stretching the control.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):