Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove platform specific, native commandBar styles #1421

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Kunal22shah
Copy link
Contributor

@Kunal22shah Kunal22shah commented Jun 12, 2024

GitHub Issue:
closes #1418
closes #1425

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah self-assigned this Jun 12, 2024
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

@Kunal22shah Kunal22shah requested a review from kazo0 June 17, 2024 18:22
@Kunal22shah Kunal22shah marked this pull request as ready for review June 17, 2024 18:23
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

@Kunal22shah Kunal22shah requested a review from kazo0 June 17, 2024 20:26
@agneszitte agneszitte requested a review from Xiaoy312 June 17, 2024 23:20
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

@kazo0
Copy link
Collaborator

kazo0 commented Jun 18, 2024

@Kunal22shah we should edit the CommandBarSamplePage.xaml to no longer navigate to a separate stack of pages and just display a normal CommandBar directly in CommandBarSamplePage.xaml. Similar to how other sample pages are done like Button and CheckBox.

You can see we currently direct people to click a Button to go to a new page where we have a CommandBar at the top and some text talking about the back button on the CommandBar. All of that isn't relevant anymore as the CommandBar is no longer being used for navigation as it was before:

image

Let me know if you want to pair to work through as I know this one is a bit messy

@Kunal22shah
Copy link
Contributor Author

@Kunal22shah we should edit the CommandBarSamplePage.xaml to no longer navigate to a separate stack of pages and just display a normal CommandBar directly in CommandBarSamplePage.xaml. Similar to how other sample pages are done like Button and CheckBox.

You can see we currently direct people to click a Button to go to a new page where we have a CommandBar at the top and some text talking about the back button on the CommandBar. All of that isn't relevant anymore as the CommandBar is no longer being used for navigation as it was before:

image

Let me know if you want to pair to work through as I know this one is a bit messy

@kazo0 Done!

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

@Kunal22shah Kunal22shah requested a review from kazo0 June 18, 2024 18:41
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net

@kazo0
Copy link
Collaborator

kazo0 commented Jun 18, 2024

@Mergifyio backport release/stable/5.1

@kazo0 kazo0 merged commit 9b440f0 into master Jun 18, 2024
18 checks passed
@kazo0 kazo0 deleted the dev/kush/commandBar-bugFix branch June 18, 2024 23:24
Copy link

mergify bot commented Jun 18, 2024

backport release/stable/5.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 18, 2024
kazo0 pushed a commit that referenced this pull request Jun 19, 2024
…1421) (#1426)

Co-authored-by: Kunal Shah <37922021+Kunal22shah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants