Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit requires FrameworkReference to be updated in WinUI target #489

Closed
nickrandolph opened this issue Mar 2, 2023 · 0 comments
Closed
Assignees
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@nickrandolph
Copy link
Contributor

Current behavior

When adding toolkit to a WinUI project, it's necessary to update the frameworkreference - hard for developers to diagnose

Expected behavior

Toolkit should be able to be added to winui project without affecting compilation or requiring additional steps

How to reproduce it (as minimally and precisely as possible)

Create new WinUI application
Add reference to toolkit
Build will fail complaining dependencies compiled with newer framework version

Proposed Fix##

Remove these lines

<ItemGroup>
<!--
If you encounter this error message:
error NETSDK1148: A referenced assembly was compiled using a newer version of Microsoft.Windows.SDK.NET.dll. Please update to a newer .NET SDK in order to reference this assembly.
This means that the two packages below must be aligned with the "build" version number of
the "Microsoft.Windows.SDK.BuildTools" package above, and the "revision" version number
must be the highest found in https://www.nuget.org/packages/Microsoft.Windows.SDK.NET.Ref.
-->
<FrameworkReference Update="Microsoft.Windows.SDK.NET.Ref" RuntimeFrameworkVersion="10.0.22621.28" />
<FrameworkReference Update="Microsoft.Windows.SDK.NET.Ref" TargetingPackVersion="10.0.22621.28" />
</ItemGroup>

@nickrandolph nickrandolph added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Mar 2, 2023
@nickrandolph nickrandolph self-assigned this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

No branches or pull requests

1 participant