Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove frameworkreference #490

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix: Remove frameworkreference #490

merged 2 commits into from
Mar 7, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #489

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Required frameworkreference in winui app when added

What is the new behavior?

Frameworkreference not required

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-490.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Mar 2, 2023

I believe @jeromelaban just added these lines back from here.
@jeromelaban is this needed?

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-490.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-490.eastus2.azurestaticapps.net

@jeromelaban
Copy link
Member

I added those to get the CI running when downgrading to .NET 6. If the CI passes, I don't see any issue.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-490.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-490.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 367ff94 into main Mar 7, 2023
@kazo0 kazo0 deleted the dev/nr/removefx2 branch March 7, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants