-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cutted text with content only long text #1017
Conversation
this is an updated branch for the textTrimming issue, for some reason the git index was broken on my side and wasn't updating the other PR branch... @kazo0 i've added the TextTrimming prop, but it's is still cutting the text if is too long... could this be related to another issue, maybe the container not clipping properly the content? any other idea? |
I'm not sure there's too much we can do if the text is too long, if there's no room for the text at a certain point it's going to have to get cut @Arieldelossantos do you have screenshots of what it looks like when its still getting cut? |
but the thing is that it's not adding the ellipsis on the cutted character :/ there's an error on the runtime test on Sample that is blocking me to deploy Android... i think it was introduced on latest main, because i've rebased the branch... |
@Arieldelossantos ah I believe these TextTrimming property doesn't exist for ContentPresenter? So I'm not sure if there is too much we can do here |
916ec76
to
75050de
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net |
ea5c537
to
c15a319
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net |
@Mergifyio backport release/stable/5.1 |
✅ Backports have been created
|
* fix: cutted text with content only long text * fix: font bindings --------- Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> (cherry picked from commit 5528d3a)
* fix: cutted text with content only long text * fix: font bindings --------- Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> (cherry picked from commit 5528d3a) Co-authored-by: Ariel De Los Santos <ariel.delossantos@nventive.com>
closes #1039
PR Type
What kind of change does this PR introduce?
What is the current behavior?
with content only tabBar item, if the text is too long, it is cutted off.
What is the new behavior?
support larger text with may tabs created.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):
https://github.com/unoplatform/uno.chefs/issues/937