Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): attached property crash #1056

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Feb 29, 2024

GitHub Issue (If applicable): closes #1055

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

using certain DrawerControlBehavior attached properties on a NavigationView would result in a compilation error:

  • DrawerBackground
  • FitToDrawerContent

What is the new behavior?

^ should not happen

PR Checklist

Please check if your PR fulfills the following requirements:

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1056.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Feb 29, 2024

@Xiaoy312 any tests we could cover this with? :D

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1056.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit d2952e9 into main Feb 29, 2024
26 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20240229/drawer-adp-crash branch February 29, 2024 22:24
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Mar 1, 2024

@Xiaoy312 any tests we could cover this with? :D

it is more of a typo that caused compilation error.
it is unlikely to regress unless i reverted back the change, or added new one of same nature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants