-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update ExtendedSplashScreen documentation #1062
Conversation
Will the fix to my remarks about the need for the splash screen in the template go to this PR or the other? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've just two comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've just two comments
|
@Mergifyio backport release/stable/6.0 |
✅ Backports have been created
|
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com>
d9006f4
to
ea0489e
Compare
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
I'm wondering if we need to cover the difference in setup if you are using the Navigation + MVUX extensions? using a ShellModel that navigates to your MainModel when it starts? |
cc @nickrandolph, @pictos |
* docs: Update ExtendedSplashScreen documentation * docs: Drop outdated members from ExtendedSplashScreen.md * docs: Address review feedback * docs: Apply suggestions from review Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> * docs: Apply suggestion from review Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com> * docs: Remove redundant property assignments from xaml snippet * docs: Update Platforms property description for ExtendedSplash * docs: update splash screen docs * docs: comments Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> * docs: comments Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> * docs: comments Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> --------- Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com> Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> (cherry picked from commit 7b1e576)
* docs: Update ExtendedSplashScreen documentation * docs: Drop outdated members from ExtendedSplashScreen.md * docs: Address review feedback * docs: Apply suggestions from review Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> * docs: Apply suggestion from review Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com> * docs: Remove redundant property assignments from xaml snippet * docs: Update Platforms property description for ExtendedSplash * docs: update splash screen docs * docs: comments Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> * docs: comments Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> * docs: comments Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> --------- Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com> Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> (cherry picked from commit 7b1e576) Co-authored-by: Luke Blevins <lukeblevins@outlook.com>
GitHub Issue (If applicable): #574
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):