Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update ExtendedSplashScreen documentation #1062

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Mar 5, 2024

GitHub Issue (If applicable): #574

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@lukeblevins lukeblevins added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2024
@lukeblevins lukeblevins self-assigned this Mar 5, 2024
@lukeblevins lukeblevins removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@lukeblevins lukeblevins marked this pull request as ready for review March 11, 2024 18:45
@lukeblevins lukeblevins requested a review from kazo0 March 11, 2024 18:45
@lukeblevins lukeblevins added the kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project label Mar 26, 2024
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
@xperiandri
Copy link

Will the fix to my remarks about the need for the splash screen in the template go to this PR or the other?

Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've just two comments

doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pedrojesus-work pedrojesus-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've just two comments

doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
@agneszitte
Copy link
Contributor

agneszitte commented Apr 1, 2024

From xperiandri:
Will the fix to my remarks about the need for the splash screen in the template go to this PR or the other?

cc @jeromelaban, @nickrandolph, @kazo0

doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
@kazo0
Copy link
Contributor

kazo0 commented Apr 3, 2024

@Mergifyio backport release/stable/6.0

Copy link
Contributor

mergify bot commented Apr 3, 2024

backport release/stable/6.0

✅ Backports have been created

doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
doc/controls/ExtendedSplashScreen.md Outdated Show resolved Hide resolved
kazo0 and others added 3 commits April 10, 2024 22:25
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
@kazo0
Copy link
Contributor

kazo0 commented Apr 11, 2024

I'm wondering if we need to cover the difference in setup if you are using the Navigation + MVUX extensions? using a ShellModel that navigates to your MainModel when it starts?

@agneszitte
Copy link
Contributor

agneszitte commented Apr 11, 2024

I'm wondering if we need to cover the difference in setup if you are using the Navigation + MVUX extensions? using a ShellModel that navigates to your MainModel when it starts?

cc @nickrandolph, @pictos

@kazo0 kazo0 merged commit 7b1e576 into main Apr 15, 2024
10 checks passed
@kazo0 kazo0 deleted the dev/lubl/extsplash-docs branch April 15, 2024 18:40
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
* docs: Update ExtendedSplashScreen documentation

* docs: Drop outdated members from ExtendedSplashScreen.md

* docs: Address review feedback

* docs: Apply suggestions from review

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

* docs: Apply suggestion from review

Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com>

* docs: Remove redundant property assignments from xaml snippet

* docs: Update Platforms property description for ExtendedSplash

* docs: update splash screen docs

* docs: comments

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

* docs: comments

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

* docs: comments

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

---------

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com>
Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
(cherry picked from commit 7b1e576)
kazo0 pushed a commit that referenced this pull request Apr 15, 2024
* docs: Update ExtendedSplashScreen documentation

* docs: Drop outdated members from ExtendedSplashScreen.md

* docs: Address review feedback

* docs: Apply suggestions from review

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

* docs: Apply suggestion from review

Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com>

* docs: Remove redundant property assignments from xaml snippet

* docs: Update Platforms property description for ExtendedSplash

* docs: update splash screen docs

* docs: comments

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

* docs: comments

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

* docs: comments

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>

---------

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
Co-authored-by: pedrojesus-work <162186634+pedrojesus-work@users.noreply.github.com>
Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
(cherry picked from commit 7b1e576)

Co-authored-by: Luke Blevins <lukeblevins@outlook.com>
@lukeblevins lukeblevins linked an issue Apr 23, 2024 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtendedSplashScreen is not documented
7 participants